Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue where dependencies with an epoch are parsed as empty #316

Merged

Conversation

radoering
Copy link
Member

  • remove duplicated and buggy method of first_pre_release() and use correct method first_prerelase()

Resolves: python-poetry/poetry#5374

  • Added tests for changed code.
  • Updated documentation for changed code.

@radoering radoering force-pushed the fix-dependencies-with-epoch-empty branch from d9df789 to bfabd4f Compare April 1, 2022 16:30
@radoering radoering requested a review from a team April 1, 2022 16:43
Copy link
Member

@abn abn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion.

tests/semver/test_helpers.py Outdated Show resolved Hide resolved
* remove duplicated and buggy method of first_pre_release() and use correct method first_prerelase()
@radoering radoering force-pushed the fix-dependencies-with-epoch-empty branch from bfabd4f to 93b773f Compare April 2, 2022 08:54
@sonarcloud
Copy link

sonarcloud bot commented Apr 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.7% 1.7% Duplication

@abn abn merged commit d7b5572 into python-poetry:master Apr 2, 2022
@finswimmer finswimmer mentioned this pull request May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Poetry reads pypi dependencies' dependencies with epoch version as <empty>
2 participants